-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport][2.2] Made logo clickable on home page #19199
[Backport][2.2] Made logo clickable on home page #19199
Conversation
Hi @gwharton. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@magento-engcom-team give me test instance |
Hi @gwharton. Thank you for your request. I'm working on Magento instance for you |
Hi @gwharton, here is your new Magento instance. |
I can confirm changes work as planned on test instance. |
This change makes not much sense imho. |
@DanielRuf using core block like in the link you posted is misuse of blocks. Method is not going to be removed any soon but should be removed at some point as there is no use for it in core. In the meantime, third-party code must be adopted to not rely on deprecated method. |
Hi @orlangur, thank you for the review. |
Hi @gwharton. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Original PR (*)
Description (*)
Removed checks that prevent the logo being clickable on the home page. It is now clickable on all pages, including the home page (essentially refreshes the homepage)
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)