Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If stock is bellow OutOfStock Threshold, a negative qty is displayed in Product List Page #19206

Merged
merged 4 commits into from
Dec 6, 2018

Conversation

khodu
Copy link
Contributor

@khodu khodu commented Nov 14, 2018

Description (*)

If stock is bellow OutOfStock Threshold, a negative qty is displayed in Product List Page

Fixed Issues (if relevant)

  1. If stock is bellow OutOfStock Threshold, a negative qty is displayed in Product List Page #9130: If stock is bellow OutOfStock Threshold, a negative qty is displayed in Product List Page

Manual testing scenarios (*)

  1. Set qty to 5 for a product, and Out of Stock threshold to 10. Save the product
    When browsing that product in the frontend a "Only -5 left" is displayed under "Out of Stock" message.
  2. Remove the block if qty is negative.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @khodu. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar rogyar self-assigned this Nov 14, 2018
@rogyar
Copy link
Contributor

rogyar commented Nov 14, 2018

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your Magento instance.
Admin access: http://34.228.235.121/i-19206-2-3-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 14, 2018
@magento-engcom-team
Copy link
Contributor

@khodu thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team
Copy link
Contributor

Hi @khodu. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants