Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9130 remove the negative qty block. #20206

Merged

Conversation

saphaljha
Copy link
Contributor

@saphaljha saphaljha commented Jan 11, 2019

Original PR: #19206

Description (*)

Fixed Issues (if relevant)

  1. If stock is bellow OutOfStock Threshold, a negative qty is displayed in Product List Page #9130: If stock is bellow OutOfStock Threshold, a negative qty is displayed in Product List Page

Manual testing scenarios (*)

  1. Set qty to 5 for a product, and Out of Stock threshold to 10. Save the product
    When browsing that product in the frontend a "Only -5 left" is displayed under "Out of Stock" message.
  2. Remove the block if qty is negative.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @saphaljha. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur
Copy link
Contributor

QA note: not sure whether this change affects MSI or if it is working correctly when backorders are enabled, please verify thoroughly.

@orlangur orlangur self-assigned this Jan 11, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Jan 11, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-3832 has been created to process this Pull Request

@ghost
Copy link

ghost commented Jan 21, 2019

Hi @saphaljha, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @saphaljha. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@saphaljha saphaljha deleted the 2.2-develop-PR-port-19206 branch February 6, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants