Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch-19344 : Fixed Sample Link Issue in Downloadable product #19344 #19378

Conversation

ansari-ziyaurrahman
Copy link
Contributor

Sample Link Issue in Downloadable product. #19344

Description (*)

Fixed issue of Sample Link Issue in Downloadable product.

Fixed Issues (if relevant)

  1. Sample Link Issue in Downloadable product. #19344: Sample Link Issue in Downloadable product

Manual testing scenarios (*)

  1. Check with new and existing product.
  2. Add new product and edit also it.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ansari-krish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur
Copy link
Contributor

@rogyar please pay attention to this PR as you're reviewing another fix of this issue.

@ansari-ziyaurrahman ansari-ziyaurrahman changed the base branch from 2.3-develop to 2.2-develop November 28, 2018 13:42
@ansari-ziyaurrahman ansari-ziyaurrahman changed the base branch from 2.2-develop to 2.3-develop November 28, 2018 13:43
@orlangur orlangur self-assigned this Apr 4, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 4, 2019

Hi @ansari-krish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@orlangur orlangur closed this Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants