Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample Link Issue in Downloadable product. #19344

Closed
ansari-ziyaurrahman opened this issue Nov 22, 2018 · 22 comments
Closed

Sample Link Issue in Downloadable product. #19344

ansari-ziyaurrahman opened this issue Nov 22, 2018 · 22 comments
Assignees
@ansari-ziyaurrahman
Labels
Component: Backend Component: Ui Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release

Comments

@ansari-ziyaurrahman
Copy link
Contributor

ansari-ziyaurrahman commented Nov 22, 2018 •
edited by agorbulin
Loading

Preconditions (*)

  1. Magento version 2.2.6

Steps to reproduce (*)

1.Create a new Downloadable product.
2.Create a Link select with file type url. Create a Sample link with file type url.
3. Save product
4. Now delete sample link only and save product again.
5. After save sample link reappearing.

Expected result (*)

  1. Sample link will be removed.

Actual result (*)

  1. Sample link is not deleted upon save.
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Nov 22, 2018
@magento-engcom-team
Copy link
Contributor

Hi @ansari-krish. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@ansari-krish do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@ansari-ziyaurrahman ansari-ziyaurrahman self-assigned this Nov 22, 2018
@agorbulin
Copy link

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @agorbulin. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @agorbulin, here is your Magento instance.
Admin access: https://i-19344-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@agorbulin
Copy link

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @agorbulin. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @agorbulin, here is your Magento instance.
Admin access: https://i-19344-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@agorbulin
Copy link

@ansari-krish
Hi,
I've reproduced issue on 2.3 develop and made clarifications in steps to reproduce

@agorbulin agorbulin self-assigned this Nov 22, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 22, 2018 •
edited by agorbulin
Loading

Hi @agorbulin. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@agorbulin
Copy link

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @agorbulin. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @agorbulin, here is your Magento instance.
Admin access: https://i-19344-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@swnsma swnsma mentioned this issue Nov 23, 2018
Closed
4 tasks
@agorbulin
Copy link

Seems fixed in pull request already #19150

@agorbulin agorbulin removed their assignment Nov 24, 2018
@ansari-ziyaurrahman
Copy link
Contributor Author

Hi @agorbulin,
That solution is not working for me. I am also working on this issue.

ansari-ziyaurrahman pushed a commit to ansari-ziyaurrahman/magento2 that referenced this issue Nov 24, 2018
@hardik-krish
patch-19344 : Fixed Sample Link Issue in Downloadable product magento…
7123628 
…#19344
@ansari-ziyaurrahman ansari-ziyaurrahman mentioned this issue Nov 24, 2018
Closed
4 tasks
@ansari-ziyaurrahman ansari-ziyaurrahman added the Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release label Nov 24, 2018
@orlangur orlangur added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release and removed Reproduced on 2.3.x. labels Nov 26, 2018
@dmytro-ch dmytro-ch added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: Ui Component: Backend labels Nov 27, 2018
@magento-engcom-team
Copy link
Contributor

@dmytro-ch Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-96693, MAGETWO-96694 were created

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Nov 27, 2018
@ansari-ziyaurrahman
Copy link
Contributor Author

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @ansari-krish. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @ansari-krish, here is your Magento instance.
Admin access: https://i-19344-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@ansari-ziyaurrahman
Copy link
Contributor Author

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @ansari-krish. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @ansari-krish, here is your Magento instance.
Admin access: https://i-19344-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

ansari-ziyaurrahman added a commit to ansari-ziyaurrahman/magento2 that referenced this issue Nov 28, 2018
@ansari-ziyaurrahman
patch-19344 : Fixed Sample Link Issue in Downloadable product magento…
eed8485 
…#19344
@ansari-ziyaurrahman ansari-ziyaurrahman mentioned this issue Nov 28, 2018
Merged
4 tasks
@ansari-ziyaurrahman ansari-ziyaurrahman added Fixed in 2.3.x The issue has been fixed in 2.3 release line and removed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 28, 2018
ansari-ziyaurrahman added a commit to ansari-ziyaurrahman/magento2 that referenced this issue Nov 29, 2018
@ansari-ziyaurrahman
patch-19344 : Fixed Sample Link Issue in Downloadable product magento…
29eea73 
…#19344
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 30, 2018
@magento-engcom-team
Copy link
Contributor

Hi @ansari-krish. Thank you for your report.
The issue has been fixed in #19431 by @ansari-krish in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.8 release.

magento-engcom-team added a commit that referenced this issue Nov 30, 2018
@magento-engcom-team
ENGCOM-3584: Sample Link Issue in Downloadable product in magento-2.2.6
871ddbb 
#19344 #19431

 - Merge Pull Request #19431 from ansari-krish/magento2:patch-2.2.6-19344
 - Merged commits:
   1. eed8485
   2. 99dbb54
   3. 29eea73
   4. 3b6307b
   5. e519bc6
magento-engcom-team pushed a commit that referenced this issue Nov 30, 2018
@sivaschenko
ENGCOM-3584: Sample Link Issue in Downloadable product in magento-2.2.6
ad04a2f 
#19344 #19431
@ansari-ziyaurrahman ansari-ziyaurrahman mentioned this issue Dec 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ansari-ziyaurrahman ansari-ziyaurrahman

Labels
Component: Backend Component: Ui Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@orlangur @dmytro-ch @magento-engcom-team @agorbulin @ansari-ziyaurrahman