Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fix: Attribute Option with zero at the beginning does not work if there is already option with the same number without the zero [REST API] #19612

Merged
merged 1 commit into from Feb 4, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 7, 2018

Original Pull Request

#19451

Description

Fix: Attribute Option with zero at the beginning does not work if there is already option with the same number without the zero

Fixed Issues

  1. Attribute Option with zero at the bigining does not work if there is already option with the same number without the zero (REST API)) #19436: Attribute Option with zero at the bigining does not work if there is already option with the same number without the zero (REST API)

Manual testing scenarios

  1. Create an attribute (select or multiselect) from the backend (example: attribute_code = brand_number)
  2. add new Option to this attribute from the backend (12345)
  3. Add new Option to this attribute by the REST API (endpoint : /V1/products/attributes/brand_number/options), json = {"option":{"label":"012345"}}
  4. expected result to have two options (12345 and 012345).

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @SikailoISM. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Catalog Release Line: 2.2 Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Dec 7, 2018
@rogyar rogyar self-assigned this Dec 7, 2018
@ghost ghost requested a review from gomencal December 11, 2018 10:00
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Dec 14, 2018
@ghost ghost requested a review from swnsma December 28, 2018 13:21
@swnsma swnsma removed their request for review January 26, 2019 14:20
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3691 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 4, 2019

Hi @SikailoISM, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Catalog Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants