Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fix: Attribute Option with zero at the beginning does not work if there is already option with the same number without the zero [REST API] #20560

Closed
wants to merge 1 commit into from

Conversation

mageprince
Copy link
Contributor

Original Pull Request

#19451

Description

Fix: Attribute Option with zero at the beginning does not work if there is already option with the same number without the zero

Fixed Issues

  1. Attribute Option with zero at the bigining does not work if there is already option with the same number without the zero (REST API)) #19436: Attribute Option with zero at the bigining does not work if there is already option with the same number without the zero (REST API)

Manual testing scenarios

  1. Create an attribute (select or multiselect) from the backend (example: attribute_code = brand_number)
  2. add new Option to this attribute from the backend (12345)
  3. Add new Option to this attribute by the REST API (endpoint : /V1/products/attributes/brand_number/options), json = {"option":{"label":"012345"}}
  4. expected result to have two options (12345 and 012345).

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ghost
Copy link

ghost commented Jan 29, 2019

Backport already created #19612

@mageprince
Copy link
Contributor Author

@SikailoISM Thanks for the information. I will close my PR :)

@mageprince mageprince closed this Jan 29, 2019
@ghost
Copy link

ghost commented Jan 29, 2019

Hi @mageprince, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant