-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue causing attribute not loading when using getList #19620
Fix issue causing attribute not loading when using getList #19620
Conversation
Hi @MiliTree. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
547fa1c
to
81a212b
Compare
As specified in issue magento#17759, CustomerRepository::getList() is unexpectedly returning NULL, when CustomerRepository::get() is correctly returning the value. Specifying the attribute as billing_company instead of company removes the conflict.
81a212b
to
d600179
Compare
@magento-engcom-team give me test instance |
Hi @MiliTree. Thank you for your request. I'm working on Magento instance for you |
Hi @MiliTree, here is your new Magento instance. |
Hi @sidolov, thank you for the review. |
…ad-company-as-custom-customer-attribute
Hi @MiliTree, thank you for your contribution! |
Hi @MiliTree. Thank you for your contribution. |
Description (*)
As specified in issue #17759,
CustomerRepository::getList()
is unexpectedly returningNULL
, whenCustomerRepository::get()
is correctly returning the value. Specifying the attribute asbilling_company
instead ofcompany
removes the conflict.Fixed Issues (if relevant)
Manual testing scenarios (*)
varchar
customer attributes, one with the codecompany
.getbyId()
:$customerById = $customerRepository->getbyId(x);
getList()
:$customerByList = $customerRepository->getList($searchCriteria->addFilter('x, y')->create());
Previously, under custom attributes, both attributes were loading correctly for
getbyId()
, butcompany
would pullNULL
when usinggetList()
Contribution checklist (*)