Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue resolved #19607. Page Not Found when deleting Attribute Set #19614 #19633

Merged
merged 2 commits into from
Dec 12, 2018
Merged

Conversation

cedcommerce
Copy link

@cedcommerce cedcommerce commented Dec 8, 2018

Description (*)
Page Not Found when deleting Attribute Set

Fixed Issues (if relevant)

  1. magento/magento2 Magento 2.3. Page Not Found when deleting Attribute Set #19607: Page Not Found when deleting Attribute Set

Manual testing scenarios (*)
1.Delete a product attribute set.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @cedcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Author

@cedcommerce cedcommerce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue resolved #19607. Page Not Found when deleting Attribute Set #19614

@cedcommerce cedcommerce changed the title Made delete request post Issue resolved #19607. Page Not Found when deleting Attribute Set #19614 Dec 8, 2018
@sivaschenko
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you

@sivaschenko sivaschenko self-assigned this Dec 8, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, here is your new Magento instance.
Admin access: https://pr-19633.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Dec 8, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3641 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@cedcommerce thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team
Copy link
Contributor

Hi @cedcommerce. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants