Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue resolved #19607. Page Not Found when deleting Attribute Set #19614 #19750

Closed

Conversation

gelanivishal
Copy link
Contributor

Original Pull Request
#19633

Description (*)
Page Not Found when deleting Attribute Set

Fixed Issues (if relevant)

  1. magento/magento2 Magento 2.3. Page Not Found when deleting Attribute Set #19607: Page Not Found when deleting Attribute Set

Manual testing scenarios (*)
1.Delete a product attribute set.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Dec 13, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3685 has been created to process this Pull Request

@VladimirZaets
Copy link
Contributor

Hi @gelanivishal. Thanks for collaboration. This issue is created for Magento 2.3 version and doesn't reproduce in Magento 2.2.
According to it we shouldn't create backport for original PR.

@ghost
Copy link

ghost commented Jan 28, 2019

Hi @gelanivishal, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants