Adding product from wishlist not adding to cart showing warning message.

[khodu]

Description (*)

Adding product from wishlist not adding to cart showing warning message.

Fixed Issues (if relevant)

1. Adding product from wishlist not adding to cart showing warning message. #9155: Adding product from wishlist not adding to cart showing warning message.

Manual testing scenarios (*)

1. Add a simple product from admin with Minimum Qty Allowed in Shopping Cart 10
2. Login in front end
3. Add product to wishlist
4. Click on wishlist.
5. Now showing allow qty as default in qty field.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @khodu. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @torhoehn, thank you for the review.
ENGCOM-3715 has been created to process this Pull Request

[sivaschenko]

Hi @khodu , there are a couple of issues that we faced while testing the PR, can you please take a look at them:

Issue 1: The 'Qty' value is not saved after updating on 'My Wish List' page
Manual testing scenario:

• Create simple product
• Create customer and Login in Storefront
• Add product to wishlist
• On 'My Wish List' page change 'Qty' field value for product
• Click 'Update Wish List' button

Issue 2: The 'Comment' value is not deleted after updating on 'My Wish List' page
Manual testing scenario:

• Create simple product
• Create customer and Login in Storefront
• Add product to wishlist
• On 'My Wish List' page add Comment for product
• Click 'Update Wish List' button
• Remove the created comment
• Click 'Update Wish List' button

[khodu]

Hi @sivaschenko

I have fixed the first issue now if qty value set is less than minimum qty for cart then it will not update but it will update the qty value if it is more than the minimum qty for cart then it will update.

for second issue i have checked in default magento 2.3 and test their and it is also generating their. so it is not relevant to this commit.

Please test my changes and if you find any issue please tell me in comment.
Thanks.

[sivaschenko]

There is a unit test failure on this pull request:

paypal/js/view/payment/method-renderer/paypal-express-abstract check smart button initialization.express-checkout-smart-buttons is initialized (from paypal_js_view_payment_method-renderer_paypal-express-abstract check smart button initialization)

TypeError: undefined is not an object (evaluating 'window.checkoutConfig.quoteData['entity_id']') in http://localhost:8001/pub/static/frontend/Magento/luma/en_US/Magento_Paypal/js/view/payment/method-renderer/in-context/checkout-express.js (line 76)

[khodu]

Hello Sergii,

I haven't change in any Js files. can you please check my pull requests.
Thanks.

[m2-assistant]

Hi @khodu, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[orlangur]

@sivaschenko @torhoehn injected variables must not be nullable.

[dmytro-ch]

@orlangur why not?
There are only two required parameters in \Magento\Wishlist\Block\AbstractBlock::__construct.
So theoretically it should also be possible to instantiate the \Magento\Wishlist\Block\Customer\Wishlist\Item\Column\Cart with only two params.
Thus we also need to make the corresponding parameters nullable in this case, don't we?

[orlangur]

@dmytro-ch because we never want to pass null explicitly. It is needed only as a default value.

[dmytro-ch]

I get it now. It does make sense.
Thanks!