Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bakport] Adding product from wishlist not adding to cart showing warning message. #22536

Merged

Conversation

niravkrish
Copy link
Contributor

Original Pull Request

#19653

Description (*)

Adding product from wishlist not adding to cart showing warning message.

Fixed Issues (if relevant)

  1. Adding product from wishlist not adding to cart showing warning message. #9155: Adding product from wishlist not adding to cart showing warning message.

Manual testing scenarios (*)

  1. Add a simple product from admin with Minimum Qty Allowed in Shopping Cart 10
  2. Login in front end
  3. Add product to wishlist
  4. Click on wishlist.
  5. Now showing allow qty as default in qty field.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 29, 2019

Hi @niravkrish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@dmytro-ch
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-22536.instances.magento-community.engineering/admin
Login: admin Password: 123123q

Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @niravkrish,
the current solution does not seem to be working.
The \Magento\Wishlist\Block\Customer\Wishlist\Item\Column\Cart cannot be instantiated due to the redundant constructor params, and namely \Magento\Catalog\Model\Product\Image\UrlBuilder which is not available in Magento 2.2.x version.
Please make sure the changes are working and compatible with Magento 2.2.x before creating a PR.

Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niravkrish, could you please squash all commits into a single commit after applying the changes in order to clean up history?
Thank you!

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4859 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented May 3, 2019

Hi @niravkrish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request May 3, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone May 3, 2019
@Rrego6
Copy link
Contributor

Rrego6 commented May 10, 2019

Hi @niravkrish . Thank you for your contribution. Unfortunately, we needed to revert this fix for the 2.2.9 release, as it includes BIC into a patch release.

magento-team pushed a commit that referenced this pull request Jun 25, 2019
…adding to cart showing warning message. #22536

- This reverts commit c62ab93.
magento-team pushed a commit that referenced this pull request Jun 25, 2019
- reverting #22536, because of Backward Incompatible changes in the patch release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants