Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #19605 Don't static compile disabled modules #19751

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Fixed #19605 Don't static compile disabled modules #19751

merged 1 commit into from
Dec 21, 2018

Conversation

shikhamis11
Copy link
Member

@shikhamis11 shikhamis11 commented Dec 13, 2018 •
edited by milindsingh
Loading

Fixed issue #19605 Don't static compile disabled modules

Summary
When running static-content:deploy, there are disabled module content in pub/static.

Examples

Disable modules that have frontend resources.
Run bin/magento setup:static-content:deploy
Observe that pub/static/... contains the resources.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur orlangur self-assigned this Dec 13, 2018
@milindsingh
Copy link
Member

@orlangur why "Community Insider: Cedcommerce" label is not added automatically by @magento-engcom-team ?

@shikhamis11
Copy link
Member Author

@orlangur may I know why you have added "Progress: on hold" label.

@orlangur orlangur removed the request for review from sivaschenko December 14, 2018 17:56
orlangur
orlangur requested changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shikhamis11 looks really clean and nice!

Please apply some minor review notes and do commit amend + force push.

on hold was to get a small feedback in Slack if there could be some undesired consequences by this change. For example, URL Rewrites are created even for disabled products so that you can enable them later without any collision.

app/code/Magento/Deploy/Collector/Collector.php Outdated
@@ -43,6 +44,13 @@ class Collector implements CollectorInterface
* @var PackageFactory
*/
private $packageFactory;

/**
* Module Manager object
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such comment is not really useful, please leave type hint only.

app/code/Magento/Deploy/Collector/Collector.php Outdated
@@ -65,11 +73,13 @@ class Collector implements CollectorInterface
public function __construct(
SourcePool $sourcePool,
FileNameResolver $fileNameResolver,
PackageFactory $packageFactory
PackageFactory $packageFactory,
Manager $moduleManager
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please inject new dependencies in backward-compatible manner: https://devdocs.magento.com/guides/v2.3/contributor-guide/backward-compatible-development/#adding-a-constructor-parameter

@shikhamis11
Copy link
Member Author

@orlangur I have made changes please check

Updated Collector.php
83f8e98 
Fixed issue magento#19605 Don't static compile disabled modules

Updated Collector.php

Updated Collector.php
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Dec 15, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-3701 has been created to process this Pull Request

@DrewML DrewML mentioned this pull request Dec 18, 2018
Open
@magento-engcom-team magento-engcom-team mentioned this pull request Dec 21, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 83f8e98 into magento:2.3-develop Dec 21, 2018
magento-engcom-team pushed a commit that referenced this pull request Dec 21, 2018
@sidolov
ENGCOM-3701: Fixed #19605 Don't static compile disabled modules #19751
d473330
@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@saphaljha saphaljha mentioned this pull request Dec 22, 2018
Merged
4 tasks
@shikhamis11 shikhamis11 mentioned this pull request Dec 27, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

Labels
Award: bug fix Community Insider: Cedcommerce community-insider-contribution Component: Deploy Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
6 participants
@shikhamis11 @magento-engcom-team @milindsingh @orlangur @sivaschenko @sidolov