Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fixed #19605 Don't static compile disabled modules #16

Merged
merged 1 commit into from
Dec 22, 2018

Conversation

saphaljha
Copy link
Owner

Original Pull Request

magento#19751
Fixed issue magento#19605 Don't static compile disabled modules

Summary
When running static-content:deploy, there are disabled module content in pub/static.

Examples

Disable modules that have frontend resources.
Run bin/magento setup:static-content:deploy
Observe that pub/static/... contains the resources.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Fixed issue magento#19605 Don't static compile disabled modules

Updated Collector.php

Updated Collector.php
@saphaljha saphaljha merged commit a6926fc into 2.2-develop Dec 22, 2018
@saphaljha saphaljha deleted the 2.2-develop-PR-port-19751 branch January 24, 2019 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant