Resolved undefined index issue for import adapter

[jaimin-ktpl]

Description (*)

Added a condition to check if 'sku' column exists in CSV file before setting its value.

Fixed Issues (if relevant)

1. Custom import adapter data validation issue #19761: Custom import adapter data validation issue

Manual testing scenarios (*)

1. Create a custom import adapter extending Magento\ImportExport\Model\Import\Entity\AbstractEntity
2. Add valid columns in getValidColumnNames() function.
   e.g. ['column1', 'column2', 'column3']
3. Create CSV file with columns stated above and add data.
4. Go to System > Import
5. Select your adapter from "Entity Type" dropdown
6. Select your CSV file in "Select File to Import" field.
7. Click on "Check Data" button
8. CSV file should get validated if column and data are available

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @jaimin-ktpl. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[sivaschenko]

Hi @jaimin-ktpl thanks for your contribution! As I can see the $skuSet variable is used to count number of processed entities. So in case, when there is no sku, this calculation will not work. Is there a way to replace the hardcoded sku field to a dynamic record identifier?

[jaimin-ktpl]

Hello @sivaschenko , Thank you for your inputs on it. Can we set an incremental variable for each valid row? Something like, $entitySet instead of $skuSet.
Or we can directly increase value of $_processedEntitiesCount for each valid rows?

[sivaschenko]

Hi @jaimin-ktpl , I think there may be no need for a variable and we may directly increment the $_processedEntitiesCount for each valid row.

I.e. that's exactly how _processedEntitiesCount handled in

magento2/app/code/Magento/CatalogImportExport/Model/Import/Product.php

Line 2483 in ddebed6

$this->_processedEntitiesCount++;

and

magento2/app/code/Magento/CustomerImportExport/Model/Import/AbstractCustomer.php

Line 193 in ddebed6

$this->_processedEntitiesCount++;

However, there is a concern about the reason the code was using the sku key at the first place. I think that's used to handle a case when import contains multiple rows for a single enitity. To count entities instead of just rows.

[jaimin-ktpl]

Hello @sivaschenko , I have updated the code to check for entity count.

[jaimin-ktpl]

@VladimirZaets , waiting for your review on this PR. Please review it when you have time.. Thanks.

[VladimirZaets]

Hi, @jaimin-ktpl. The ticked already reviewed and currently in processing status. Thanks

[p-bystritsky]

QA passed.

[m2-assistant]

Hi @jaimin-ktpl, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.