Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Resolved undefined index issue for import adapter #22180

Conversation

amol2jcommerce
Copy link
Contributor

Original Pull Request

#19765

Description (*)

Added a condition to check if 'sku' column exists in CSV file before setting its value.

Fixed Issues (if relevant)

  1. Custom import adapter data validation issue #19761: Custom import adapter data validation issue

Manual testing scenarios (*)

  1. Create a custom import adapter extending Magento\ImportExport\Model\Import\Entity\AbstractEntity
  2. Add valid columns in getValidColumnNames() function.
    e.g. ['column1', 'column2', 'column3']
  3. Create CSV file with columns stated above and add data.
  4. Go to System > Import
  5. Select your adapter from "Entity Type" dropdown
  6. Select your CSV file in "Select File to Import" field.
  7. Click on "Check Data" button
  8. CSV file should get validated if column and data are available

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 5, 2019

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-5030 has been created to process this Pull Request

@Nazar65 Nazar65 self-assigned this May 7, 2019
@Nazar65
Copy link
Member

Nazar65 commented May 7, 2019

HI @amol2jcommerce based on this comment #19761 (comment) fix for forward port must be reverted and refactored.

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5030 has been created to process this Pull Request

@Nazar65
Copy link
Member

Nazar65 commented May 21, 2019

QA Passed ✔️

@m2-assistant
Copy link

m2-assistant bot commented May 22, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this pull request May 22, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.10 milestone May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants