Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent display of token when save for later is not selected #19767

Merged
merged 3 commits into from
May 8, 2019

Conversation

pmclain
Copy link
Contributor

@pmclain pmclain commented Dec 14, 2018

Description

This sets the token isVisible value to false if
VaultConfigProvider::IS_ACTIVE_CODE is not set in the payment's
additionalInformation property. The value is not set when placing orders
through the admin panel, unless the save for later checkbox is selected. This
caused all admin order payment to be visible in the stored payment method
section in the storefront.

Testing on 2.3 depends on #19764

Fixed Issues (if relevant)

  1. Create new order from backend saves the credit card when it is told not to #19515

Manual testing scenarios

  1. Enable PayFlow Pro payment method for credit card transactions with vault allowed.
  2. Create orders in admin panel using PayFlow Pro
  3. After placing Admin order, new stored payment methods should only be visible to the customer if "Save for Later" option was selected during order placement.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

This sets the token `isVisible` value to faluse if
`VaultConfigProvider::IS_ACTIVE_CODE` is not set in the payment's
`additionalInformation` property. The value is not set when placing orders
through the admin panel, unless the save for later checkbox is selected. This
caused all admin order payment to be visible in the stored payment method
section in the storefront.

Fixes magento#19515

Testing on 2.3 depends on magento#19764
@magento-engcom-team
Copy link
Contributor

Hi @pmclain. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@dmytro-ch
Copy link
Contributor

@pmclain,
thank you for your contribution!

Unfortunately, the original issue is considered as expected behavior.
So we have to close current PR for now.

Thank you!

@dmytro-ch dmytro-ch closed this Mar 22, 2019
@ghost
Copy link

ghost commented Mar 22, 2019

Hi @pmclain, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@pmclain
Copy link
Contributor Author

pmclain commented Mar 22, 2019

@dmytro-ch The expected behaviour outlined in the issue does NOT work.

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-4839 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented May 8, 2019

Hi @pmclain, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants