-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Vault token visibility option #21970
Conversation
Hi @joni-jones. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @rogyar, thank you for the review. |
✔️ QA passed |
The pull request introduces performance degradation on admin save order:
|
@sivaschenko do you have additional build details? The fix should not add additional SQL queries. |
Duplicates #19767 |
Hi @joni-jones thank you for the pull request! However, I have to close it as it is a duplicate to #19767 submitted earlier - let's collaborate to deliver that pull request to mainline |
Hi @joni-jones, thank you for your contribution! |
Fixed incorrect behavior for
Save for later use
checkbox if it wasn't checked.Relates to #19515.