Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Vault token visibility option #21970

Closed
wants to merge 2 commits into from

Conversation

joni-jones
Copy link
Contributor

Fixed incorrect behavior for Save for later use checkbox if it wasn't checked.
Relates to #19515.

@magento-engcom-team
Copy link
Contributor

Hi @joni-jones. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4603 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@sivaschenko
Copy link
Member

The pull request introduces performance degradation on admin save order:

Save Order (Admin Create Order): 8.3% (mainline = 12 | team = 13) -> DEGRADATION

@joni-jones
Copy link
Contributor Author

@sivaschenko do you have additional build details? The fix should not add additional SQL queries.

@pmclain
Copy link
Contributor

pmclain commented Apr 22, 2019

Duplicates #19767

@sivaschenko sivaschenko self-assigned this Apr 29, 2019
@sivaschenko
Copy link
Member

Hi @joni-jones thank you for the pull request! However, I have to close it as it is a duplicate to #19767 submitted earlier - let's collaborate to deliver that pull request to mainline

@m2-assistant
Copy link

m2-assistant bot commented Apr 29, 2019

Hi @joni-jones, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@joni-jones joni-jones deleted the G#19515 branch February 19, 2020 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants