Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My-account-page-Recently-Ordered-check-box-misaligned-on-tab-portrait… #20155

Conversation

ajay2jcommerce
Copy link

…-view ::my account page check box misaligned on tab portrait view

Description (*)

Fixed Issues (if relevant)

  1. My account page "Recently Ordered" check box misaligned on tab portrait view My account page "Recently Ordered" check box misaligned on tab portrait view  #20143
  2. ...

Manual testing scenarios (*)

  1. placed order with login customer on my account page in sidebar check resend order product.

  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…-view ::my account page check box misaligned on tab portrait view
@magento-engcom-team
Copy link
Contributor

Hi @ajay2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jan 10, 2019

CLA assistant check
All committers have signed the CLA.

…x misaligned on tab portrait view

@ajay2jcommerce this is fine now.
@ajay2jcommerce
Copy link
Author

Hi @magento-engcom-team please review.

@ajay2jcommerce
Copy link
Author

Hi @magento-engcom-team @miguelbalparda please review.

@sdzhepa
Copy link
Contributor

sdzhepa commented Feb 7, 2019

Hi @ajay2jcommerce

Could you please provide style fixes according to code review comments?

Thank you for contribution and collaboration!

Ajay added 2 commits February 7, 2019 17:20
@ajay2jcommerce
Copy link
Author

Hi @zanilee, @sdzhepa updated code as per style fixes according to code review comments.
Please review.

Thanks

@sdzhepa
Copy link
Contributor

sdzhepa commented Feb 7, 2019

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, here is your Magento instance.
Admin access: https://i-20155-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@sdzhepa
Copy link
Contributor

sdzhepa commented Feb 7, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, here is your new Magento instance.
Admin access: https://pr-20155.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, thank you for the review.
ENGCOM-4168 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 12, 2019

Hi @ajay2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dmytro-ch
Copy link
Contributor

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your Magento instance.
Admin access: https://i-20155-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants