Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] My-account-page-Recently-Ordered-check-box-misaligned-on-tab-portrait… #21171

Conversation

amol2jcommerce
Copy link
Contributor

@amol2jcommerce amol2jcommerce commented Feb 13, 2019

Description (*)

#20143 : My account page "Recently Ordered" check box misaligned on tab portrait view

Fixed Issues (if relevant)

  1. My-account-page-Recently-Ordered-check-box-misaligned-on-tab-portrait… #20155: My account page "Recently Ordered" check box misaligned on tab portrait view

Manual testing scenarios (*)

  1. placed order with login customer on my account page in sidebar check resend order product.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@dmytro-ch
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-21171.instances.magento-community.engineering/admin
Login: admin Password: 123123q

Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amol2jcommerce,
thank you for your contribution.
Could you please fix the issues mentioned in the review?

@amol2jcommerce
Copy link
Contributor Author

Hi @dmytro-ch branch updated. please review.

@dmytro-ch
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-21171.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4243 has been created to process this Pull Request

@sivaschenko
Copy link
Member

Hi @amol2jcommerce, we are not able to reproduce this issue on 2.2-develop, can you please double check if the fix is needed for this version.
image

@amol2jcommerce
Copy link
Contributor Author

Hi @sivaschenko, I recheck & this issue on 2.2-develop not reproduce.

Thanks

@ghost
Copy link

ghost commented Feb 18, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants