Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct base path to check if setup folder exists #20182

Merged
merged 2 commits into from
Apr 16, 2019

Conversation

JeroenVanLeusden
Copy link
Member

@JeroenVanLeusden JeroenVanLeusden commented Jan 10, 2019

Description (*)

Current implementation checks the path base/data/web/magento2/pubsetup which is incorrect. It should be /data/web/magento2/pub/setup.

Fixed Issues (if relevant)

  1. Web Setup Wizard not visible in backend magento 2.1.9 #11892
  2. Web Setup Wizard not visible in backend (V.2.1.2) ONGOING #7623

Manual testing scenarios (*)

  1. Install Magento and set doc root is pub/.
  2. Symlink setup folder to pub.
  3. Web Setup Wizard should be visible under System > Web Setup Wizard but it's not.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @JeroenVanLeusden. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@JeroenVanLeusden
Copy link
Member Author

@orlangur Can you give me an update of the status?

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4711 has been created to process this Pull Request

@Nazar65
Copy link
Member

Nazar65 commented Apr 12, 2019

HI @JeroenVanLeusden i'm found two issue that you try to fix #11892,
#7623

@soleksii
Copy link

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Apr 16, 2019

Hi @JeroenVanLeusden, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants