Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Use correct base path to check if setup folder exists #6

Closed
wants to merge 576 commits into from

Conversation

JeroenVanLeusden
Copy link
Owner

Original Pull Request

magento#20182

Description (*)

Current implementation checks the path base/data/web/magento2/pubsetup which is incorrect. It should be /data/web/magento2/pub/setup.

Fixed Issues (if relevant)

  1. Web Setup Wizard not visible in backend magento 2.1.9 magento/magento2#11892
  2. Web Setup Wizard not visible in backend (V.2.1.2) ONGOING magento/magento2#7623

Manual testing scenarios (*)

  1. Install Magento and set doc root is pub/.
  2. Symlink setup folder to pub.
  3. Web Setup Wizard should be visible under System > Web Setup Wizard but it's not.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

StasKozar and others added 30 commits March 22, 2019 10:50
… minimize the cache objects magento#21819

 - Merge Pull Request magento#21819 from ihor-sviziev/magento2:2.2-varnish-remove-marketing-get-params
 - Merged commits:
   1. d009436
 - Merge Pull Request magento#17371 from afirlejczyk/magento2:bugfix/7283-insignificant-stores-sorting-issue
 - Merged commits:
   1. f168593
   2. 81fc5aa
   3. c4fbe49
   4. 8910b68
   5. 7bc52b9
   6. c0e78e0
   7. 471de67
   8. c60df27
   9. 448a333
   10. e6b17ad
…loy: Error while waiting for package deployed
…ddress validator magento#21719

 - Merge Pull Request magento#21719 from Bartlomiejsz/magento2:feature/backport_22_fix_21692_incorrect_constructor
 - Merged commits:
   1. 068eedf
   2. 8a4cfa4
   3. 43cc9a4
   4. f77f54d
   5. cece086
   6. 67b1d0a
…agento#21939

 - Merge Pull Request magento#21939 from hiren0241/magento2:2.2-develop-PR-backport-21376
 - Merged commits:
   1. 843a0b5
…ixed Negative order amount in dashboard when viewing particular store data
… same as default checkout agreements magento#21943

 - Merge Pull Request magento#21943 from eduard13/magento2:2.2-develop-PR-port-21778
 - Merged commits:
   1. d8fd378
   2. e283d9a
   3. fff0b40
   4. 7026859
   5. a0c3ac5
 - Merge Pull Request magento#21892 from amol2jcommerce/magento2:advanced-Search-layout-2.2
 - Merged commits:
   1. 67b732c
   2. af75c5a
ameysar and others added 28 commits April 11, 2019 17:05
 - merged latest code from mainline branch
Accepted Public Pull Requests:
 - magento#22140: Backport for Magento 2.2 - Fixes variables in configuration not being� (by @hostep)
 - magento#21945: [Backport] Trigger contentUpdate on reviews load (by @eduard13)
 - magento#20392: Backport.  Success message is not showing when creating invoice & shipment simultaniously # (by @XxXgeoXxX)


Fixed GitHub Issues:
 - magento#15972: Since Magento 2.2.1, certain variables in the configuration get resolved to their actual value (reported by @hostep) has been fixed in magento#22140 by @hostep in 2.2-develop branch
   Related commits:
     1. 0b0fc92
…ag & drop via Visual Merchandiser in category

- skipped @magentoIndexerDimensionMode annotation and tests
- fixed MAGETWO-99019: Magento\Install\Test\TestCase\InstallTest is failing on php 7.0
 - merged latest code from mainline branch
Accepted Public Pull Requests:
 - magento#22227: [Backport] Fix negative subtotal when full discount applied with tax calculation magento#10790 (by @ilnytskyi)
 - magento#22232: [Backport]Magento should create log if an observer not implement ObserverInterface (by @Nazar65)
 - magento#22181: [Backport] Contact us layout in I-pad not proper (by @amol2jcommerce)
 - magento#20844: [Backport] Fixed Minicart close button overlapping (by @mage2pratik)
 - magento#18980: [Backport] Fix for currency update in crontab area (by @denispapec)


Fixed GitHub Issues:
 - magento#10790: Tax rate + 100% discount results in negative grand total (reported by @dankocherga) has been fixed in magento#22227 by @ilnytskyi in 2.2-develop branch
   Related commits:
     1. f68cff7
     2. 8501089
     3. 7bbc018
     4. b30b1bb
     5. a7f65ac
     6. 0d1a0b0
     7. ea79937
     8. ec8bbce
     9. 17f7b77
     10. d5be0aa
     11. 98a1561

 - magento#21755: Magento should create a log entry if an observer does not implement ObserverInterface (reported by @bnymn) has been fixed in magento#22232 by @Nazar65 in 2.2-develop branch
   Related commits:
     1. 4223d2b

 - magento#20614: Minicart close button overlapping in shipping address section whenever any user open minicart in mobile view on the checkout page (reported by @mage2pratik) has been fixed in magento#20844 by @mage2pratik in 2.2-develop branch
   Related commits:
     1. 3a4a1d2

 - magento#18580: Currency rates not updated by crontab (reported by @jcourtei) has been fixed in magento#18980 by @denispapec in 2.2-develop branch
   Related commits:
     1. 737f396
[TSG] Backporting for 2.2 (pr90) (2.2-develop)
@JeroenVanLeusden JeroenVanLeusden deleted the 2.2-develop-PR-port-20182 branch April 26, 2019 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.