Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14882 product types xml doesn t allow numbers in model instance #20617

Conversation

lisovyievhenii
Copy link
Contributor

Description

The files product_types_base.xsd, product_options.xsd, import.xsd, export.xsd doesn't allow modules with the numbers in the name.

Fixed Issues

  1. product_types.xml doesn't allow numbers in modelInstance #14882: product_types.xml doesn't allow numbers in modelInstance

Manual testing scenarios (*)

  1. Have a module with numbers in Vendor's or module's name.
  2. Create product_types.xml or any other file, mentioned above.

AR: XSD validation error that modelName is invalid.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Fix module and models name pattern for product_types_base.xsd, product_options.xsd, import.xsd, export.xsd. Adjust unit tests, related to these files
@magento-engcom-team
Copy link
Contributor

Hi @lisovyievhenii. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Catalog Component: ImportExport Release Line: 2.3 Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Jan 25, 2019
@novikor novikor self-requested a review January 26, 2019 13:51
Copy link
Contributor

@novikor novikor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Please improve your regular expressions:
At the moment, it passes classes which start with a number in case name starts with \

@lisovyievhenii lisovyievhenii removed the request for review from vpodorozh January 28, 2019 13:44
Copy link
Contributor

@novikor novikor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@magento-engcom-team
Copy link
Contributor

Hi @swnsma, thank you for the review.
ENGCOM-4065 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 20, 2019

Hi @lisovyievhenii, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Feb 20, 2019
@lisovyievhenii lisovyievhenii deleted the 14882-product-types-xml-doesn-t-allow-numbers-in-modelInstance branch March 6, 2019 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants