Back port pull 20617 #21598
Merged
Back port pull 20617 #21598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.2 develop
2.2 develop
…ce. Fix module and models name pattern for product_types_base.xsd, product_options.xsd, import.xsd, export.xsd. Adjust unit tests, related to these files
|
Hi @lisovyievhenii. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
magento-engcom-team
added
Component: Catalog
Component: ImportExport
Release Line: 2.2
Partner: ISM eCompany
orlangur
approved these changes
Mar 6, 2019
|
Hi @orlangur, thank you for the review. |
ghost
added
Progress: testing in progress
and removed
Progress: ready for testing
labels
|
✔️ QA Passed |
ghost
added
Progress: extended testing
Progress: accept
and removed
Progress: testing in progress
Progress: extended testing
labels
|
Hi @lisovyievhenii, thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
Backport of #20617
Description
The files
product_types_base.xsd,product_options.xsd,import.xsd,export.xsddoesn't allow modules with the numbers in the name.Fixed Issues
#14882:
product_types.xmldoesn't allow numbers inmodelInstanceManual testing scenarios
Have a module with numbers in Vendor's or module's name.
Create
product_types.xmlor any other file, mentioned above.AR: XSD validation error that
modelNameis invalid.