Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email-template-popup-blank-fixes:: Email Template Information Insert … #20730

Conversation

nadim2jcommerce
Copy link
Contributor

@nadim2jcommerce nadim2jcommerce commented Jan 28, 2019

Description (*)

2.3.0

Fixed Issues (if relevant)

  1. magento/magento2 Email Template Information Insert Variable popup blank  #20111: Email Template Information Insert Variable popup blank

Manual testing scenarios (*)

1.Go to admin>>MARKETING>>Email Templates>> edit the template

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @nadim2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3996 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@nadim2jcommerce thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@okorshenko okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019
@VladimirZaets
Copy link
Contributor

Hi @nadim2jcommerce. Thanks for collaboration.

Your fix provides next problem:
Fatal Error message after insert variable to template
Steps to reproduce:

Login to Admin;
Go to Marketing->Communications->Email Templates;
Click on "Add New Template" button;
Select "New Account" template from the list for example;
Click on "Load Template" button;
Fill all required fields;
Click on "Save Template" button;
Click on created before template for edit;
Click on "Insert Variable..." button;
Select "Add URL" link from the list for example;
Click on "Save Template" button;
Click on "Preview" link in the template grid
We got Fatal Error message.

@sidolov
Copy link
Contributor

sidolov commented Mar 20, 2019

@nadim2jcommerce , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Mar 20, 2019
@ghost
Copy link

ghost commented Mar 20, 2019

Hi @nadim2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants