-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipad-view-order-summary-block #20856
ipad-view-order-summary-block #20856
Conversation
Hi @dipti2jcommerce. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@@ -148,14 +148,14 @@ | |||
} | |||
|
|||
.product-item-name-block { | |||
display: table-cell; | |||
display: block; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dipti2jcommerce. The parent block contain .product-item-inner
class that has display: table;
, so use display:block
instead of display:table-cell
in table isn't correct way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @VladimirZaets ,
I have made modification in code for ipad view as per your request and its working fine.please check.
Thanks,
Dipti
Hi @dipti2jcommerce. We will retest your PR and leave feedback. Thanks |
Hi @dipti2jcommerce, thank you for your contribution! |
In checkout page product price not align proper in order summary block for iPad view
Description (*)
1.Go to checkout page by adding product
2.In order summary block product price not align proper in ipad view
Fixed Issues (if relevant)
In checkout page product price not align proper in order summary block for ipad view #20855
Manual testing scenarios (*)
actual result
after fixing:
Contribution checklist (*)