Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipad-view-order-summary-block #20856

Conversation

dipti2jcommerce
Copy link

In checkout page product price not align proper in order summary block for iPad view

Description (*)

1.Go to checkout page by adding product
2.In order summary block product price not align proper in ipad view

Fixed Issues (if relevant)

In checkout page product price not align proper in order summary block for ipad view #20855

Manual testing scenarios (*)

actual result
alignmentcheckout

after fixing:
alignmentcorrect

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @dipti2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@@ -148,14 +148,14 @@
}

.product-item-name-block {
display: table-cell;
display: block;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dipti2jcommerce. The parent block contain .product-item-inner class that has display: table;, so use display:block instead of display:table-cell in table isn't correct way.

Copy link
Author

@dipti2jcommerce dipti2jcommerce Feb 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @VladimirZaets ,

I have made modification in code for ipad view as per your request and its working fine.please check.

Thanks,
Dipti

@VladimirZaets
Copy link
Contributor

Hi @dipti2jcommerce. We will retest your PR and leave feedback. Thanks

@ghost
Copy link

ghost commented Feb 24, 2019

Hi @dipti2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants