Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue thumbnail image too big in order summary checkout #28644

Closed
wants to merge 1 commit into from
Closed

Fix issue thumbnail image too big in order summary checkout #28644

wants to merge 1 commit into from

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Jun 9, 2020 •
edited by VladimirZaets
Loading

Description (*)

This fix bring the fix for image thumbnail in order summary area in checkout page
Previous image too big visible
#1 Recheck styles visual for all (mobile | ipad | desktop) view
since this review #20856 (review) from @VladimirZaets

Related Pull Requests

#20856

Fixed Issues (if relevant)

  1. Fixes Thumbnail product image in checkout page order summary too big #28634

Manual testing scenarios (*)

1.Add any product type to cart
2.Go to checkout page
3.Open area order summary

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 9, 2020

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@sdzhepa
Copy link
Contributor

sdzhepa commented Jun 11, 2020

Hello @mrtuvn

Thank you for the fix!
Please review the comment #28634 (comment) and update your PR(I see you have fixed 2 issues)

@ghost ghost added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Jun 11, 2020
@mrtuvn mrtuvn force-pushed the fix-issue-28634-big-thumbnail-order-summary-checkout branch from 173e032 to 88e908b Compare June 11, 2020 02:22
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jun 11, 2020

@sdzhepa reverted my change so this PR will not conflict with changes in #28546
Only add new clean code in styles

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jun 11, 2020

@VladimirZaets can you recheck review

@VladimirZaets
Copy link
Contributor

@magento run all tests

@VladimirZaets
Copy link
Contributor

Hi @mrtuvn. Thanks for collaboration. I reran the build but due to changes only in styles I can approve it right now

@ghost ghost assigned VladimirZaets Jun 11, 2020
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-7670 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@VladimirZaets VladimirZaets added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jun 11, 2020
@mrtuvn mrtuvn force-pushed the fix-issue-28634-big-thumbnail-order-summary-checkout branch from f6bcbb1 to 80d0157 Compare June 11, 2020 22:54
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jul 14, 2020

@magento run all tests

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jul 26, 2020 •
edited
Loading

@VladimirZaets Hi any update on this

@engcom-Delta engcom-Delta self-assigned this Jul 28, 2020
engcom-Delta
engcom-Delta requested changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@engcom-Delta engcom-Delta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VladimirZaets Could you review last commit?

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jul 28, 2020 •
edited
Loading

@engcom-Delta is this commit in #28546 has cherry pick or merge to 2.4-develop ?

VladimirZaets
VladimirZaets previously approved these changes Jul 28, 2020
View reviewed changes
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-7670 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jul 29, 2020

@magento run all tests

engcom-Delta
engcom-Delta requested changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@engcom-Delta engcom-Delta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mrtuvn I have checked PR with latest commit and issue still exist
Tablet view:
image
Destop view:
image
image

Could you take a look?

@ghost ghost dismissed VladimirZaets’s stale review July 30, 2020 07:41

Pull Request state was updated. Re-review required.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jul 30, 2020

@engcom-Delta here is my screen in local setup with latest commit show summary area
Screenshot from 2020-07-30 17-04-32

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jul 30, 2020

Here is desktop view
Screenshot from 2020-07-30 17-07-13

@mrtuvn mrtuvn force-pushed the fix-issue-28634-big-thumbnail-order-summary-checkout branch from 80d0157 to ddf3122 Compare July 30, 2020 10:10
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jul 30, 2020

@engcom-Delta just synced my PR branch with 2.4-develop code

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jul 30, 2020

@magento run all tests

@VladimirZaets
Copy link
Contributor

Hi @mrtuvn. Thanks for collaboration. The issue is closed due that it was fixed by internal team in the scope of 2.4.0 release. The details and screenshots you can see in the issue. Feel free to reopen your PR if the issue is still reproducible

@m2-assistant
Copy link

m2-assistant bot commented Jul 30, 2020

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@mrtuvn mrtuvn deleted the fix-issue-28634-big-thumbnail-order-summary-checkout branch August 1, 2020 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Delta engcom-Delta engcom-Delta requested changes

@VladimirZaets VladimirZaets VladimirZaets left review comments

Assignees

@VladimirZaets VladimirZaets

@engcom-Delta engcom-Delta

Labels
Area: Design/Frontend Area: Frontend Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: needs update QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) Release Line: 2.4 Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Thumbnail product image in checkout page order summary too big
5 participants
@mrtuvn @sdzhepa @VladimirZaets @magento-engcom-team @engcom-Delta