-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Related to (fix issue 24735) (MC-34950 - Wrong style for Product in Checkout Cart) #28546
Related to (fix issue 24735) (MC-34950 - Wrong style for Product in Checkout Cart) #28546
Conversation
Hi @engcom-Echo. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. |
@magento run all tests |
Hi @lenaorobei, thank you for the review.
|
Commit was cherry-picked and will be delivered to |
Hi @engcom-Echo, thank you for your contribution! |
But 'product_thumbnail_image' is still set to 75px (vendor/magento/theme-frontend-blank/etc/view.xml) So the image actually now shows up at 37.5px wide..? Edit: nevermind it's actually 'mini_cart_product_thumbnail', which was updated in blank |
Description (*)
Minor change to fix MC-34950.
MC-34950 was found during Regression Testing for 2.4.0 release
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Expect result: The product image should be placed to the left of the product description.
Questions or comments
Contribution checklist (*)