Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Related to (fix issue 24735) (MC-34950 - Wrong style for Product in Checkout Cart) #28546

Closed

Conversation

engcom-Echo
Copy link
Contributor

@engcom-Echo engcom-Echo commented Jun 5, 2020

Description (*)

Minor change to fix MC-34950.
MC-34950 was found during Regression Testing for 2.4.0 release

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Go to Storefront and add any Simple product or other (The product must have an image)
  2. Go to mini-cart
  3. Click "Proceed to Checkout'
  4. Check a product image on right bar "Order Summary"

Expect result: The product image should be placed to the left of the product description.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 5, 2020

Hi @engcom-Echo. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@engcom-Echo
Copy link
Contributor Author

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-7624 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@lenaorobei lenaorobei added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jun 5, 2020
@engcom-Alfa engcom-Alfa self-assigned this Jun 5, 2020
@sdzhepa sdzhepa added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Jun 5, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Luma theme

Manual testing scenario:

  1. Go to Storefront and add any Simple product with an image to Cart;
  2. Go to mini-cart

Actual Result: ✔️ Image has good quality

Screenshot from 2020-06-05 23-59-47

  1. Click on "Proceed to Checkout" button;
  2. Check a product image on right bar "Order Summary";

Before: ✖️ The image has incorrect position and size

Screenshot from 2020-06-05 23-54-22

After: ✔️ The product image placed to the left of the product description and has correct size

screenshot_37

  1. Fill all required fields and click on Next button;

Before: ✖️ The image has incorrect position and size

screenshot_39

After: ✔️ The product image placed to the left of the product description and has correct size

screenshot_38

On a mobile device: ✔️ Image in mini cart isn't blurred on iPhone

Screenshot from 2020-06-06 00-02-08
Screenshot from 2020-06-08 13-33-27

Blank theme

Manual testing scenario:

  1. Go to Storefront and add any Simple product with an image to Cart;
  2. Go to mini-cart

Actual Result: ✔️ Image has good quality

Screenshot from 2020-06-08 13-04-35

  1. Click on "Proceed to Checkout" button;
  2. Check a product image on right bar "Order Summary";

Before: ✖️ The image has incorrect position and size

screenshot_40

After: ✔️ The product image placed to the left of the product description and has correct size

screenshot_43

  1. Fill all required fields and click on Next button;

Before: ✖️ The image has incorrect position and size

screenshot_42

After: ✔️ The product image placed to the left of the product description and has correct size

screenshot_44

On a mobile device: ✔️ Image in mini cart isn't blurred on iPhone
Screenshot from 2020-06-08 13-29-54

Screenshot from 2020-06-08 13-28-59

@sdzhepa sdzhepa added this to the 2.4.0 milestone Jun 8, 2020
@lenaorobei
Copy link
Contributor

Commit was cherry-picked and will be delivered to 2.4.0.

@lenaorobei lenaorobei closed this Jun 8, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 8, 2020

Hi @engcom-Echo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@BB-000
Copy link

BB-000 commented Oct 12, 2021

But 'product_thumbnail_image' is still set to 75px (vendor/magento/theme-frontend-blank/etc/view.xml)

So the image actually now shows up at 37.5px wide..? ☹️

Edit: nevermind it's actually 'mini_cart_product_thumbnail', which was updated in blank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Checkout Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: extended testing Release Line: 2.4 Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants