Adding Italian language package #21013
Conversation
|
|
|
Hi @WaPoNe. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
Adding Italian language package |
There was a problem hiding this comment.
Hello @WaPoNe thanks for your contribution.
In order to make static test go green, in language pack's composer.json please remove version and set dependency from magento/framework to *.
Finally, add "magento/language-it_it": "*" in the replace node of root composer.json
|
@WaPoNe: out of curiosity, what does this PR actually achieve? I don't see any translations in your PR? Maybe I'm missing something obvious here, but I never quite understood what those built-in language packs do in Magento, there's just nothing in there? |
…ento/framework version
|
@aleron75 : Done! |
|
Conflicts resolved |
|
@hostep : you're right. My PR does not achieve anything special; it just adds Italian language to built-in language packs ;-) |
|
@WaPoNe: ok, and can you explain what this means exactly? Does it help in some way, or how can we see the improvement which is being done by this PR? |
Hello @hostep I see the point of your question but I also think that if other language packs are there in the same format we should wonder what is the value of all of them, not only of this one. In other words, should we accept this or remove the others? |
|
I agree, never quite understood what those other empty language packs do in core Magento. |
|
@WaPoNe: well I can't really give a hard decision here, since I'm only a community contributor, not a member of the core Magento team :) I'm currently trying to understand why these are here in the first place, to understand the history and trying to figure out if they still have a purpose. So, they got introduced in 974d259 In that commit, I can see some csv files in various modules which still got translated texts, for example, in the csv file for French in the Catalog module: So at that point, these (empty) translations packs probably made the non-English translations from the various Then fast forward 17 months, and I find a new commit, where most of these non-English Strangely enough the current codebase still contains some of these non-English $ find . -type f -iname 'fr_FR.csv'
./app/code/Magento/Ui/i18n/fr_FR.csv
./app/code/Magento/ProductVideo/i18n/fr_FR.csv
./app/code/Magento/Search/i18n/fr_FR.csv
./app/code/Magento/Msrp/i18n/fr_FR.csv
./app/code/Magento/Swatches/i18n/fr_FR.csv
./app/code/Magento/Developer/i18n/fr_FR.csvNone of these seem to contain translations in French at first sight, just English. Anyways, so far for looking back in the history. My conclusion is: these empty language packs are probably a left-over from the days where Magento was still maintaining translations themselves. This later got outsourced to the community using crowdin. The idea might have been to regularly pull in translations from crowdin in the Magento core, but until this day, this doesn't seem to have happened and might not happen at all in the future, I have no idea if there are still plans in that direction? (@buskamuza ?) If there are no further plans from Magento to take care of non-English translations, it would make sense to remove the current language modules from the core, except for the English one, so these directories can probably be removed:
Next to those directories, the following files should probably be removed as well:
Next to those, there are some German translation files being used in the integration tests, but I don't think those can be removed:
@WaPoNe: maybe hold of a few days until somebody from core Magento can give some feedback here, that might be safest? |
|
@hostep : ok.. we'll wait for the safest decision by the Magento core members. |
|
@WaPoNe: after talking a little bit with @vkublytskyi on Slack in the
But we also can't remove the current existing language packs:
What we can do however is removing that list of non-English csv files inside the various Magento modules. I've just created a PR for this over here: #21927 I hope you don't mind me closing this PR? |
|
Hi @WaPoNe, thank you for your contribution! |
Description (*)
Contribution checklist (*)