Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing obsolete non-English translation files, these aren't transla… #21927

Conversation

hostep
Copy link
Contributor

@hostep hostep commented Mar 25, 2019

…ted and serve no purpose.

Description (*)

This PR is a result of some research done in #21013 (comment)

This removes a bunch of csv files, which were a left over in Magento after all the others got deleted in 9736c70b800

List of files to be removed was created using:
find . -type f -iname '*.csv' -path '*i18n*' | grep -v 'en_US.csv' | grep -v 'dev/tests/'

The only file from this list of deleted files which actually contains a translation is https://github.com/magento/magento2/blob/2.3.0/app/code/Magento/Search/i18n/pt_BR.csv, but I don't think it makes sense to ship Magento with a single translation in Portuguese?

Fixed Issues (if relevant)

  1. None that I could find

Manual testing scenarios (*)

  1. Not relevant

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @hostep. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @vkublytskyi, thank you for the review.
ENGCOM-4578 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

Notice: QA not applicable

@m2-assistant
Copy link

m2-assistant bot commented Apr 5, 2019

Hi @hostep, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants