Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

products-in-category-checkbox-not-align-properly #21022

Conversation

priti2jcommerce
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. products in category checkbox not align properly #21021
  2. ...

Manual testing scenarios (*)

  1. Go to admin >> Catalog >> Categories
  2. Select any category having product

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @priti2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@dmytro-ch
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-21022.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@dmytro-ch dmytro-ch self-assigned this Feb 6, 2019
@dmytro-ch
Copy link
Contributor

Hi @priti2jcommerce,
thank you for your contribution!

It does not seem to be a bug.
screen shot 2019-02-06 at 3 30 21 pm

As for me, it even look better before aupplying the fixes.
Thank you.

@dmytro-ch dmytro-ch closed this Feb 6, 2019
@ghost
Copy link

ghost commented Feb 6, 2019

Hi @priti2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@priti2jcommerce
Copy link
Contributor Author

@magento-engcom-team
Copy link
Contributor

Hi @priti2jcommerce. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @priti2jcommerce, here is your Magento instance.
Admin access: https://i-21022-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@priti2jcommerce
Copy link
Contributor Author

priti2jcommerce commented Feb 7, 2019

@dmytro-ch
I have checked and found the bug on the testing instance and you have checked on pr instance with fixes,thats why it look proper.
image

@priti2jcommerce priti2jcommerce removed the request for review from dmytro-ch February 7, 2019 05:27
@dmytro-ch dmytro-ch self-requested a review February 7, 2019 06:26
@dmytro-ch
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-21022.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@dmytro-ch
Copy link
Contributor

dmytro-ch commented Feb 7, 2019

Hi @priti2jcommerce,
sure I know that there is the current solution on my screenshot.
I just wanted to mention that it still looks strange a little bit, event after the fixes.
Nevertheless, it's a matter of taste. :)

Could you please check the issue appeared after the latest changes.
The following areas are not clickable:
screen shot 2019-02-07 at 8 43 02 am

It should be possible to select the item by clicking the row.
Looks like there was same not clickable area previously, but it was not so large.
screen shot 2019-02-07 at 8 42 16 am

Thank you!

@priti2jcommerce
Copy link
Contributor Author

Hi @dmytro-ch ,

Thanks for the update, made the changes for this.

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4174 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 13, 2019

Hi @priti2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants