Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Cache Management mass-action checkbox alignment #21257

Closed
wants to merge 3 commits into from

Conversation

mage2pratik
Copy link
Contributor

@mage2pratik mage2pratik commented Feb 15, 2019

Description (*)

Fixed Cache Management mass-action checkbox alignment

Fixed Issues (if relevant)

  1. Magento backend Cache Management mass action checkbox alignment is not proper. #21255: Magento backend Cache Management mass action checkbox alignment is not proper.

Manual testing scenarios (*)

  1. Login to admin panel
  2. Navigate on System -> Tools (Cache Management)
  3. Observe the mass action check-box

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4288 has been created to process this Pull Request

Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mage2pratik,
thank you for your contribution!
Could you please also revert the changes made for functional test app/code/Magento/Sales/Test/Mftf/Section/OrdersGridSection.xml in #21022.

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4288 has been created to process this Pull Request

@sivaschenko
Copy link
Member

sivaschenko commented Feb 18, 2019

Hi @mage2pratik , thank you for the pull request! This PR is basically a revert of the fix for #21021 . Will you be able to provide a correct fix for that issue in this PR as well?

@dmytro-ch
Copy link
Contributor

Hi @sivaschenko,
thank you for the update!
I had a concern regarding the "bug" fixed in #21022.
So, if this solution breaks something, I would rather revert these changes than apply new fixes.
Looking forward to your answer. :)

Thank you!

@sivaschenko
Copy link
Member

Hi @dmytro-ch I completely agree with your concern, I simply was wondering if we could not just revert the fix, but correct it.

@dmytro-ch
Copy link
Contributor

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your Magento instance.
Admin access: https://i-21257-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@dmytro-ch
Copy link
Contributor

@sivaschenko, please note, the alignment issue has already been fixed in #20237.
I briefly checked the solution on 2.3-develop and did not notice additional issues.

Thank you!

@sivaschenko
Copy link
Member

@mage2pratik @dmytro-ch looks like both #21255 and #21021 are fixed on latest 2.3-develop, can you please confirm that and close this PR if necessary

@dmytro-ch
Copy link
Contributor

Yes, the bug with backend Cache Management mass action checkbox alignment has been has been also fixed in #20237.
Thank you!

@dmytro-ch dmytro-ch closed this Feb 19, 2019
@ghost
Copy link

ghost commented Feb 19, 2019

Hi @mage2pratik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@mage2pratik mage2pratik deleted the patch-9 branch March 26, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants