Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: User Role Checkbox alignement. #20237

Merged

Conversation

suryakant-krish
Copy link
Contributor

Description (*)

Backend: User Role Checkbox alignement.

Fixed Issues (if relevant)

This is direct pull request as per Magento reviewer suggested,

Manual testing scenarios (*)

  1. Login into admin panel > System > User Roles > Click on Adminstrator User > Role User > Look checkbox alignment.

  2. Actual Result
    actual-result

  3. Expected Result
    expected-result

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @suryakant-krish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@speedy008
Copy link
Contributor

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @speedy008, here is your Magento instance.
Admin access: https://i-20237-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@speedy008 speedy008 added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed labels Jan 12, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3870 has been created to process this Pull Request

@suryakant-krish
Copy link
Contributor Author

@magento-engcom-team,

Please review this PR.

# Conflicts:
#	app/design/adminhtml/Magento/backend/Magento_Ui/web/css/source/module/_data-grid.less
@magento-engcom-team magento-engcom-team merged commit 25d9d11 into magento:2.3-develop Feb 18, 2019
@ghost
Copy link

ghost commented Feb 18, 2019

Hi @suryakant-krish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Feb 18, 2019
nainesh2jcommerce pushed a commit to nainesh2jcommerce/magento2 that referenced this pull request Feb 19, 2019
@sdzhepa sdzhepa removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed labels Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants