Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 27633 duplicate property style #27642

Merged
merged 6 commits into from
May 21, 2020
Merged

Fix 27633 duplicate property style #27642

merged 6 commits into from
May 21, 2020

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Apr 7, 2020 •
edited
Loading

Description (*)

Just remove duplicate property line for checkbox element in grid.
Previously we have 2 declares with same property vertical-align in same element

Related Pull Requests

Fixed Issues (if relevant)

  1. Sales Order grid checkbox alignment issue in Admin #27633: Sales Order grid checkbox alignment issue in Admin

Manual testing scenarios (*)

  1. Magento 2.3.4+
  2. Go to backend and see any grid checkbox

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 7, 2020

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ihor-sviziev
Copy link
Contributor

Seems like issue was added in #20237

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Apr 7, 2020

@ihor-sviziev thanks for your reference link
This not high priority PR just clean up from my perspective view. We no need duplicate thing in code for do one job

@rogyar rogyar self-assigned this Apr 8, 2020
@rogyar rogyar added Award: bug fix Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Apr 8, 2020
@rogyar
Copy link
Contributor

rogyar commented Apr 8, 2020

The failing tests are not related to the current fix

rogyar
rogyar previously approved these changes Apr 8, 2020
View reviewed changes
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7281 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Apr 10, 2020
engcom-Alfa
engcom-Alfa requested changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@engcom-Alfa engcom-Alfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mrtuvn

During testing, we faced the issues

Manual testing scenario:

  1. Go to Admin -> System -> Cache Management

Actual Result: ✖️ Checkboxes have the wrong position

Screenshot from 2020-04-10 14-06-10

  1. Go to Admin -> System -> Index Management

Actual Result: ✖️ The same result as with cache

Screenshot from 2020-04-10 14-08-32

@mrtuvn Could you take a look?

Thanks!

@ghost ghost dismissed rogyar’s stale review April 10, 2020 11:11

Pull Request state was updated. Re-review required.

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7281 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented Apr 13, 2020 •
edited
Loading

✔️ QA Passed

Before:
screenshotfin2

After:
screenshotfin1

@engcom-Kilo engcom-Kilo self-assigned this Apr 13, 2020
@VladimirZaets VladimirZaets added this to the 2.4.1 milestone Apr 15, 2020
@VladimirZaets VladimirZaets added Priority: P3 May be fixed according to the position in the backlog. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Apr 15, 2020
@ghost ghost added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Apr 30, 2020
@sdzhepa sdzhepa linked an issue Apr 30, 2020 that may be closed by this pull request
Sales Order grid checkbox alignment issue in Admin #27633
Closed
@sdzhepa sdzhepa removed the Priority: P3 May be fixed according to the position in the backlog. label Apr 30, 2020
@sdzhepa sdzhepa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label May 20, 2020
@slavvka slavvka mentioned this pull request May 21, 2020
Closed
slavvka added a commit that referenced this pull request May 21, 2020
@slavvka
ENGCOM-7281: Fix 27633 duplicate property style #27642
668ad8a
@slavvka slavvka merged commit 1474cd6 into magento:2.4-develop May 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 21, 2020

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@mrtuvn mrtuvn deleted the fix-27633-duplicate-property-style branch June 7, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

@suryakant-krish suryakant-krish Awaiting requested review from suryakant-krish

@engcom-Alfa engcom-Alfa Awaiting requested review from engcom-Alfa

Assignees

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Kilo engcom-Kilo

Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
None yet
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

Sales Order grid checkbox alignment issue in Admin
9 participants
@mrtuvn @ihor-sviziev @rogyar @magento-engcom-team @engcom-Alfa @sdzhepa @VladimirZaets @slavvka @engcom-Kilo