Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quantity-not-center-align-on-review-order #21038

Conversation

nainesh2jcommerce
Copy link
Contributor

@nainesh2jcommerce nainesh2jcommerce commented Feb 7, 2019

Description (*)

On multishipping checkout review order page quantity not center align and border bottom appearing twice on mobile view

Manual testing scenarios (*)

  1. on mobile dive
  2. add product to cart with login customer
  3. go to cart page
  4. Check Out with Multiple Addresses
  5. Go to Shipping Information
  6. Continue to Billing Information
  7. Go to Review Your Order
  8. check quantity and subtotal of product

Expected result (*)

image

Actual result (*)

image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @nainesh2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@nainesh2jcommerce
Copy link
Contributor Author

Hi @dmytro-ch, I have updated this PR as per your review in PR #21039.

Thanks!

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4175 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 3fc1709 into magento:2.3-develop Feb 14, 2019
@ghost
Copy link

ghost commented Feb 14, 2019

Hi @nainesh2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants