border-appearing-twice-on-subtotal

[nainesh2jcommerce]

Description (*)

On multishipping checkout review order page border bottom appearing twice for subtotal on mobile view

Manual testing scenarios (*)

1. on mobile dive
2. add product to cart with login customer
3. go to cart page
4. Check Out with Multiple Addresses
5. Go to Shipping Information
6. Continue to Billing Information
7. Go to Review Your Order
8. check subtotal of product

Expected result (*)

Actual result (*)

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @nainesh2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[dmytro-ch]

Hi @nainesh2jcommerce,
what is the reason of creating two different PRs to add rules in the same LESS file for the same block?

            .data.table {
                &:extend(.abs-checkout-order-review all);
                &.table-order-review {
                    > tbody {
                        > tr {
                            > td.col.subtotal {
                                border-bottom: none;
                            }
                        }
                    }
                }
            }

and

            .data.table {
                &:extend(.abs-checkout-order-review all);
                &.table-order-review {
                    > tbody {
                        > tr {
                            > td.col.qty {
                                text-align: center;
                            }
                        }
                    }
                }
            }

Please combine the current PR (#21039), #21038 into one PR in order to make it easier to process these changes for Magento Community Engineering team.

Thank you!

[nainesh2jcommerce]

Hi @dmytro-ch, Thanks for the update. I have combined this PR in to #21038, can you please review.
Closing this PR.

Thanks!

[ghost]

Hi @nainesh2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.