Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect empty cart button behavior #21500

Closed
wants to merge 4 commits into from
Closed

Fix incorrect empty cart button behavior #21500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4cdcb74
Merge remote-tracking branch 'upstream/2.3-develop' into 2.3-develop
wojtekn Feb 11, 2019
f6656f9
Merge remote-tracking branch 'upstream/2.3-develop' into 2.3-develop
wojtekn Feb 18, 2019
2ec9970
Merge remote-tracking branch 'upstream/2.3-develop' into 2.3-develop
wojtekn Feb 28, 2019
47a8930
Fix clear shopping cart button behavior when enter key is pressed to …
wojtekn Feb 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions app/code/Magento/Checkout/view/frontend/templates/cart/form.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,6 @@
<span><?= /* @escapeNotVerified */ __('Continue Shopping') ?></span>
</a>
<?php endif; ?>
<button type="submit"
name="update_cart_action"
data-cart-empty=""
value="empty_cart"
title="<?= $block->escapeHtml(__('Clear Shopping Cart')) ?>"
class="action clear" id="empty_cart_button">
<span><?= /* @escapeNotVerified */ __('Clear Shopping Cart') ?></span>
</button>
<button type="submit"
name="update_cart_action"
data-cart-item-update=""
Expand All @@ -67,6 +59,14 @@
class="action update">
<span><?= /* @escapeNotVerified */ __('Update Shopping Cart') ?></span>
</button>
<button type="submit"
name="update_cart_action"
data-cart-empty=""
value="empty_cart"
title="<?= $block->escapeHtml(__('Clear Shopping Cart')) ?>"
class="action clear" id="empty_cart_button">
<span><?= /* @escapeNotVerified */ __('Clear Shopping Cart') ?></span>
</button>
<input type="hidden" value="" id="update_cart_action_container" data-cart-item-update=""/>
</div>
</form>
Expand Down
4 changes: 4 additions & 0 deletions app/design/frontend/Magento/luma/Magento_Checkout/web/css/source/module/_cart.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,6 +558,10 @@
&:extend(.abs-shopping-cart-items-desktop all);
.actions.main {
text-align: right;

.action.clear {
float: left;
}
}
}

Expand Down