Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect empty cart button behavior #21500

Closed
wants to merge 4 commits into from
Closed

Fix incorrect empty cart button behavior #21500

wants to merge 4 commits into from

Conversation

wojtekn
Copy link
Contributor

@wojtekn wojtekn commented Feb 28, 2019

Description

PR changes order of cart form submit elements to have Update Shopping Cart first in the DOM, to make sure it is used as submit button when Enter key is pressed. There is also change to the theme styling to adjust Clear Shopping Cart position after changing buttons order.

Fixed Issues

  1. Cart is emptied when enter is pressed after changing product quantity #21499

Manual testing scenarios

  1. Add any product to cart
  2. Navigate to the cart
  3. Un-hide "Clear Shopping Cart" button which is hidden in Luma by default by running this in browser console:
    jQuery("#empty_cart_button").show();
  4. Change item quantity in the input
  5. Press "Enter"

Expected result is to have product quantity updated.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @wojtekn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Feb 28, 2019

CLA assistant check
All committers have signed the CLA.

@wojtekn
Copy link
Contributor Author

wojtekn commented Feb 28, 2019

@magento-engcom-team
Copy link
Contributor

Hi @wojtekn. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @wojtekn, here is your new Magento instance.
Admin access: https://pr-21500.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@wojtekn
Copy link
Contributor Author

wojtekn commented Feb 28, 2019

I can't reproduce problem anymore on provided test instance.

@rogyar rogyar self-assigned this Feb 28, 2019
@rogyar
Copy link
Contributor

rogyar commented Feb 28, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-21500.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4396 has been created to process this Pull Request

@VladimirZaets
Copy link
Contributor

Hi @wojtekn. Thanks for collaboration. We have another PR that resolve the same issue.
According to fix, we prefer that PR because that PR resolve the problem in JS code that gives more flexibility and scalability.
Thank for your work.

@ghost
Copy link

ghost commented Mar 5, 2019

Hi @wojtekn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants