Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Cart is emptied when enter is pressed after changing product quantity #21509

Merged

Conversation

lfluvisotto
Copy link
Contributor

@lfluvisotto lfluvisotto commented Feb 28, 2019

Description (*)

Fix: Cart is emptied when enter is pressed after changing product quantity

Fixed Issues (if relevant)

#21499: Cart is emptied when enter is pressed after changing product quantity

Manual testing scenarios (*)

Go to the input qty and press enter key

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @lfluvisotto. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@lfluvisotto
Copy link
Contributor Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @lfluvisotto. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @lfluvisotto, here is your new Magento instance.
Admin access: https://pr-21509.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-4400 has been created to process this Pull Request

@wojtekn
Copy link
Contributor

wojtekn commented Feb 28, 2019

This PR duplicates #21500

@soleksii
Copy link

soleksii commented Mar 6, 2019

✔️ QA Passed

@soleksii
Copy link

soleksii commented Mar 6, 2019

Re-checked ✔️ QA Passed

@wojtekn
Copy link
Contributor

wojtekn commented Mar 8, 2019

It looks that this PR fixes issue from #21499, but it breaks another use case:

  1. Add any product to cart
  2. Navigate to the cart
  3. Un-hide "Clear Shopping Cart" button which is hidden in Luma by default by running this in browser console:
    jQuery("#empty_cart_button").show();
  4. Use Tab key to focus Clear Shopping Cart button
  5. Press "Enter"

Now the only way to trigger Clear Shopping Cart button is to click it with mouse, it's not possible to submit this action using keyboard anymore.

@ghost
Copy link

ghost commented Mar 11, 2019

Hi @lfluvisotto, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit fd3344b into magento:2.3-develop Mar 11, 2019
@chichitsai0517
Copy link

It looks that this PR fixes issue from #21499, but it breaks another use case:

  1. Add any product to cart
  2. Navigate to the cart
  3. Un-hide "Clear Shopping Cart" button which is hidden in Luma by default by running this in browser console:
    jQuery("#empty_cart_button").show();
  4. Use Tab key to focus Clear Shopping Cart button
  5. Press "Enter"

Now the only way to trigger Clear Shopping Cart button is to click it with mouse, it's not possible to submit this action using keyboard anymore.

Hi I am sorry but I am not a programmer. But how do we achieve this? Where do we add the " jQuery("#empty_cart_button").show();"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants