Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fix: Cart is emptied when enter is pressed after changing product quantity #21512

Conversation

lfluvisotto
Copy link
Contributor

@lfluvisotto lfluvisotto commented Feb 28, 2019

Original Pull Request

#21509

Description (*)

Fix: Cart is emptied when enter is pressed after changing product quantity

Fixed Issues (if relevant)

#21499: Cart is emptied when enter is pressed after changing product quantity

Manual testing scenarios (*)

Go to the input qty and press enter key

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @lfluvisotto. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@lfluvisotto
Copy link
Contributor Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @lfluvisotto. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @lfluvisotto, here is your new Magento instance.
Admin access: https://pr-21512.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@VladimirZaets VladimirZaets self-assigned this Feb 28, 2019
@sidolov sidolov self-assigned this Feb 28, 2019
@lfluvisotto
Copy link
Contributor Author

Hi @sidolov , @VladimirZaets , @sivaschenko

The PR made for the version 2.3.X was already merged.

#21509

Are you guys going to merge also this PR into 2.2.X ?

@sivaschenko
Copy link
Member

Sure, thanks for notification @lfluvisotto !

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-4630 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Apr 5, 2019

Hi @lfluvisotto, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Apr 5, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Apr 5, 2019
@lfluvisotto lfluvisotto deleted the magento-2.2-develop-issue-21499 branch November 22, 2019 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants