[Backport] Misconfigured aria-labelledby for product tabs #21532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Good afternoon, I find out attribute aria-labelledby is misconfigured. It must be declared for the content of the tab and not the title, in particular, for a parent tag. Ilan PARMENTIER Source : https://www.w3.org/TR/wai-aria-practices/examples/tabs/tabs-1/tabs.html#sc1_label
|
Hi @amol2jcommerce. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
magento-engcom-team
added
Area: Frontend
Component: Catalog
Release Line: 2.2
Partner: Two Jay
partners-contribution
|
Hi I already asked you this but you didn't reply. Did you contact the original author of all the backports you are doing? |
rogyar
approved these changes
Mar 2, 2019
|
Hi @rogyar, thank you for the review. |
ghost
added
Progress: testing in progress
and removed
Progress: ready for testing
labels
|
✔️ QA passed |
|
Hi @amol2jcommerce, thank you for your contribution! |
magento-engcom-team
pushed a commit
that referenced
this pull request
Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#21302
Good afternoon,
I find out attribute aria-labelledby is misconfigured for jquery ui tabs in product page.
It must be declared for content of tab and not title.
Ilan PARMENTIER
Source :
https://www.w3.org/TR/wai-aria-practices/examples/tabs/tabs-1/tabs.html#sc1_label