Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fix Broken Tax Rate Search Filter Admin grid #21521 #21535

Merged
merged 2 commits into from
Apr 3, 2019

Conversation

tuyennn
Copy link
Member

@tuyennn tuyennn commented Mar 1, 2019

Description (*)

Inside Tax Rate admin, while search criteria with main table tax_calculation_rule code and tax_calculation_rate code will caused where clause is ambiguous

Fixed Issues (if relevant)

  1. magento/magento2#21521: Broken Tax Rate Search Filter - SQLSTATE[23000] Broken Tax Rate Search Filter - SQLSTATE[23000] #21521

Manual testing scenarios (*)

  1. Go to Admin -> Stores -> Taxes -> Tax Rules

  2. Add a tax rule

  3. Search tax rule using both Name and Tax Rate fields
    eg. Name = Alabama & Tax Rate = US-AL

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Backport for: #21701

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 1, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @tuyennn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@tuyennn
Copy link
Member Author

tuyennn commented Mar 3, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @tuyennn. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @tuyennn, here is your new Magento instance.
Admin access: https://pr-21535.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@tuyennn
Copy link
Member Author

tuyennn commented Mar 4, 2019

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @tuyennn. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @tuyennn, here is your Magento instance.
Admin access: https://i-21535-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@ghost ghost assigned aleron75 Mar 5, 2019
@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-4434 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@tuyennn thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@VasylShvorak
Copy link
Contributor

✔️ QA passed

Copy link
Contributor

@sidolov sidolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tuyennn , in order to keep consistency between versions we accepting pull requests to 2.3-develop first. Please, create pull request with the same changes to 2.3-develop

@tuyennn
Copy link
Member Author

tuyennn commented Mar 12, 2019

@sidolov New pull request base on 2.3-develop was created here #21701

@sidolov sidolov changed the title Fix Broken Tax Rate Search Filter Admin grid #21521 [Backport] Fix Broken Tax Rate Search Filter Admin grid #21521 Mar 14, 2019
@tuyennn
Copy link
Member Author

tuyennn commented Mar 15, 2019

Duplicate #21758

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-4434 has been created to process this Pull Request

@m2-assistant
Copy link

m2-assistant bot commented Apr 3, 2019

Hi @tuyennn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants