Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Broken Tax Rate Search Filter Admin grid #21521 #21701

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

tuyennn
Copy link
Member

@tuyennn tuyennn commented Mar 12, 2019

Description (*)

Inside Tax Rate admin, while search criteria with main table tax_calculation_rule code and tax_calculation_rate code will caused where clause is ambiguous

Fixed Issues (if relevant)

  1. magento/magento2#21521: Broken Tax Rate Search Filter - SQLSTATE[23000] Broken Tax Rate Search Filter - SQLSTATE[23000] #21521

Manual testing scenarios (*)

  1. Go to Admin -> Stores -> Taxes -> Tax Rules

  2. Add a tax rule

  3. Search tax rule using both Name and Tax Rate fields
    eg. Name = Alabama & Tax Rate = US-AL

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @tuyennn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@dmytro-ch
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-21701.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4480 has been created to process this Pull Request

@soleksii
Copy link

✔️ QA Passed

@ghost
Copy link

ghost commented Mar 14, 2019

Hi @tuyennn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@tuyennn tuyennn deleted the 2.3-issues-21521 branch April 2, 2019 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants