Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #21750 remove translation of product attribute label #21751

Merged

Conversation

Karlasa
Copy link
Contributor

@Karlasa Karlasa commented Mar 14, 2019

Description (*)

Removed translation of attribute label

Fixed Issues (if relevant)

  1. Product attribute labels are translated #21750: Product attribute labels are translated

Manual testing scenarios (*)

Add product attribute into product page.
Add store specific label
add same phrase into translation file
Expected result ()
Attribute label is not translated and kept as set in admin (store specific label)
Actual result (
)
Attribute label is translated

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Area: Frontend Component: Catalog Release Line: 2.3 Partner: Vaimo Pull Request is created by partner Vaimo partners-contribution Pull Request is created by Magento Partner labels Mar 14, 2019
@VladimirZaets VladimirZaets self-assigned this Mar 15, 2019
@soleksii soleksii self-assigned this Mar 15, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-4503 has been created to process this Pull Request

@soleksii
Copy link

✔️ QA Passed

@p-bystritsky p-bystritsky self-assigned this Mar 18, 2019
@sidolov sidolov changed the base branch from 2.3-develop to 2.2-develop March 18, 2019 18:58
@sidolov sidolov changed the base branch from 2.2-develop to 2.3-develop March 18, 2019 18:58
@magento-engcom-team magento-engcom-team merged commit a07eda3 into magento:2.3-develop Mar 20, 2019
@ghost
Copy link

ghost commented Mar 20, 2019

Hi @Karlasa, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants