Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] fix #21750 remove translation of product attribute label #21864

Merged

Conversation

mage2pratik
Copy link
Contributor

Original Pull Request

#21751

Description (*)

Removed translation of attribute label

Fixed Issues (if relevant)

  1. Product attribute labels are translated #21750: Product attribute labels are translated

Manual testing scenarios (*)

Add product attribute into product page.
Add store specific label
add same phrase into translation file
Expected result ()
Attribute label is not translated and kept as set in admin (store specific label)
Actual result (
)
Attribute label is translated

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4548 has been created to process this Pull Request

@soleksii
Copy link

soleksii commented Mar 21, 2019

Hi @mage2pratik ! I've checked PR and looks like that these changes doesn't solve the problem.
You need to create backport to this pr: #20482 and after the merge (backport to 20482) I think your PR changes solve the issue!

Thanks!

@mage2pratik
Copy link
Contributor Author

Created Backport #21872

@soleksii
Copy link

✔️ QA Passed

@ghost
Copy link

ghost commented Mar 26, 2019

Hi @mage2pratik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@mage2pratik mage2pratik deleted the 2.2-develop-PR-port-21751 branch March 26, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants