Fixed #22052 Customer account confirmation is overwritten by backend customer save

[shikhamis11]

Fixed #22052 Customer account confirmation is overwritten by backend customer save

Preconditions (*)

1. Clean Magento setup 2.3.1
2. Set the account confirmation to "Yes" by visiting store > configuration > Customers > Customer Configuration > Create New Account Options > Require Emails Confirmation

Steps to reproduce (*)

1. Create a new customer account on frontend by visiting "Create a new account" link from header
2. Open Magento backend with valid credentials
3. Go to Customer > All Customers
4. Open the newly created customer and please notice the value of "Confirmed email:" is "Confirmation Required"
5. Now click on "Save and continue"
6. Now Please notice the value of "Confirmed email:" is "Confirmed"

Customer account while opening customer

After saving customer

Expected result (*)

1. Customer account should confirm by email link not from by saving customer from backend

Actual result (*)

1. Customer account is getting confirmed even customer did not click on email activation link

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[m2-assistant]

Hi @shikhamis11. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[dmytro-ch]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-22147.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[dmytro-ch]

Hi @shikhamis11,
thank you for your contribution!

There is a unit test failure with the current solution.

Magento\Customer\Test\Unit\Model\Customer\DataProviderWithDefaultAddressesTest::testGetData

Could you please update it?

Thank you.

[swnsma]

May be related #21394

[shikhamis11]

Hi @swnsma
Thanks for your update . I checked that PR doesn't fix the current issue .

[shikhamis11]

@dmytro-ch I have fixed unit test failure Please check

[magento-engcom-team]

Hi @dmytro-ch, thank you for the review.
ENGCOM-4678 has been created to process this Pull Request

[VasylShvorak]

✔️ QA passed

[m2-assistant]

Hi @shikhamis11, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.