Refactor/avoid recursion #362
Conversation
There was a problem hiding this comment.
Thanks, it's always good to avoid recursion in Elisp if possible! :) But this still needs a bit of work. ;)
This probably counts as a non-trivial change (in terms of lines of code), so in order to install it we'd need you to assign the copyright to the Free Software Foundation, as Dash is copyrighted by the FSF. Do you already have such an assignment on file? If not, would you be willing to submit one? The process is relatively simple and painless, and once it's done you'll be able to contribute to Emacs itself and other core packages as well. See (info "(emacs) Copyright Assignment") for more info on this. You can find the relevant form here: https://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.future.
TIA.
basil-conto
added
copyright
|
Hi! Many thanks for checking this so quickly!
Done - I'll update here when I have received a reply. |
|
sorry @basil-conto I did not just deliberately request a new review - misunderstood the refresh icon, thought it would reload stuff but instead it sent you a request. Again, sorry. |
|
No worries! Now I know what it does too :) |
What's the status on this @perweij? If you're waiting more than a week or two for a response from the copyright clerk, feel free to ping them. |
|
Ping. |
|
Hi! Now I have assigned the copyright to the Free Software Foundation. The process is completed, and I have received the final PDF file from FSF, so we should be able to proceed. Sorry for the looong delay! |
* dash.el (--partition-after-pred): New anaphoric macro. (-partition-after-pred): Use it. * dev/examples.el (-partition-after-pred): Test it.
* dash.el (--partition-after-pred): Simplify. Extend docstring. (-partition-after-pred): Extend docstring. * dev/examples.el (-partition-after-pred): Extend tests. * README.md: * dash.texi: Regenerate docs. Re: magnars#362.
basil-conto
force-pushed
the
refactor/avoid-recursion
branch
from
fb1d305
to
609b7e7
Compare
No worries, and thanks for the nice and efficient implementation! |
The recursive nature of
-partition-after-predcauses problems when processing long lists where these limits are exceeded:max-lisp-eval-depthmax-specpdl-sizeI have tried to rewrite it as an iterative macro instead. It seems to work, and passes the tests, but if you have time, please check the code for possible improvements.