Rewrite -partition-after-pred to avoid recursion #379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akirak
changed the title
akirak
force-pushed
the
rewrite/partition-after-pred
branch
from
c33a8b8
to
6caec68
Compare
akirak
changed the title
Indeed, but have you tried the patch proposed in #362? |
basil-conto
added
duplicate
|
I didn't know of that PR. Yes, I have worked on exactly the same issue. I don't have an anaphoric version, so the existing one would be better. Thanks. |
|
Thanks for confirming. Then let's wait a little bit longer for @perweij to respond, and in the meantime I'll check if their copyright papers are in order yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a situation where this function fails with the deep nesting error. I think it's generally better to avoid recursion whenever possible.