Allow Ember canary tests to fail #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdebarros
force-pushed
the
allow-canary-fail
branch
from
1617fcb to
11c15da
Compare
sdebarros
changed the title
sdebarros
force-pushed
the
allow-canary-fail
branch
3 times, most recently
from
bf7cb1b to
942367b
Compare
marcoow
approved these changes
Jan 24, 2021
|
Ah sorry, I'd say ideally we'd want beta tests to pass |
marcoow
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the original intention was to allow Ember canary tests to fail, but the current configuration wasn't doing that (see https://github.com/simplabs/ember-simple-auth/runs/1746492928?check_suite_focus=true).
This change fixes that.