Fix tests failing in master #2262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoow
approved these changes
Jan 24, 2021
There was a problem hiding this comment.
Makes sense 👍
I think we can also replace the dependency with a simple <link> tag to load the bootstrap styles from their CDN – I don't think we use any of the addon's additional functionality. Bootstrap as such might be a good thing to keep (for now) since moving to our own CSS would be a bit of a bigger step and we'd be adding more code to maintain that's not actually relevant for ESA.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests in master are failing for the canary and beta versions, it seems to be related to the latest Ember not working well with a dependency of the
ember-bootstrapwe have.This is a temporary solution to allow us to release version 3.1.0, since we only use
ember-bootstrapfor the test apps it shouldn't be an issue. Upgradingember-bootstrapon the actual app, breaks tests for Ember 3.12. I think we should consider removing theember-bootstrapdependency and just have our own CSS.